Menu

Show posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Show posts Menu

Messages - Tobias

#46
Quote from: menion on May 15, 2016, 06:09:01
Hello, interesting. Are you sure you have latest Beta version from Google Play?
It says 3.16.2.12 at startup. Just checked again, it works now with 240dpi, but not with 480dpi.
#47
Quote from: menion on May 12, 2016, 09:51:15
If you wanna try, since yesterday is on Google Play new Beta version ( if you use it ).
Finally found the time to test the latest beta it in an emulator @480dpi. Still same behavior as above, all patterns 8dp/16dp/32dp/64dp. Did you remove the rounding again?


#48
Quote from: menion on May 13, 2016, 13:05:27
Damn, it's more then expected. Hmm ... oki, I'll have to separate it and round scaling only for images for areas ...
And lines with images :)
#49
Quote from: LocusUser#1 on May 13, 2016, 12:47:10
Hmm, for me all Symbols and Texts are smaller. 

Left is 3.16.2, Right is 3.16.2.12

You probably have a device with an odd scale factor, something like 480 dpi. Those are affected and that's what we talked about above when rounding to integers with a power of 2 can happen if this isn't limited to svg patterns.
#50
Thanks, I'll look into it as soon as I find the time.
#51
Quote from: menion on May 09, 2016, 18:41:54
because this task is not so simple (handle differently scale for areas and for paths)
I was afraid you would say that :-)
No need for hurry and/or special test version, I'll use fixed size patterns until it works with scalable ones.
But I think other themes (and users) will be affected if not only scaling for patterns will change. We'll see.
#52
Quote from: menion on May 09, 2016, 12:23:03
To keep consistency, this change apply on all values defined with "dp" units in theme.xml file, so no worry.
So this applies to stroke-width, symbol-size etc. as well?
If yes I think it's better to keep them scaling in the normal way, which works perfect except for patterns with svg/dp.
#53
Quote from: menion on May 09, 2016, 10:01:42
For now, I've at least improved DPI scaling, so now values of density used for scaling will be rounded on all devices to 1, 2, 4 values, so if you will use sizes for your images as 8, 16, 32, 64, you will be fine. Unfortunately my device I use for daily use has density that cause no such troubles, but quick test in emulator and it seems to work fine. Ok for now?

That's fine, thanks for the quick fix. I'm fine with any working solution.

I forget to mention that this should also apply to lines with a pattern, not just areas.

Rounding up or down makes sense for me (e.g. 3->4, 2.5->2) etc., as this helps to read the maps. With those crazy high density devices it's often better to have it larger (my testing device is also not troubled at 320dpi, so I also have to emulate this).
#54
Hi Menion,
thanks for testing!

Quote from: menion on May 08, 2016, 11:26:37
So, you suggestion is to round this multiplier to whole numbers that multiply 2 to always correctly fit tiles? So 2.5 round to "2", 3.5 round to "2" (maybe up to 4)? Correct?
That's the easiest solution, but only fits pattern with a side length of a power of 2.

QuoteOr any better solution already used in MapsForge?
I checked this out bit more. At first I thought it works there because tiles are resized by dpi the same way as patterns (e.g. 512px tiles at 320dpi, so 64px patterns get 128px, 768px tiles at 480dpi, 64px get 192px etc.)
But with apps like OruxMaps which use a fixed tile size of 512px no matter what dpi scaling still works perfect, even if pattern side length is not a power of 2, so this is more elegant. The solution is that patterns are scaled without stopping at tile borders, see the attached screenshot with a tile size of 512px and 480 dpi, and a pattern of 64px scaled to 192px. White are pattern borders, black are tile borders.



#55
I think Locus uses a tile size of 256 for all densities.
If you're right about your theory how scaling works there is no possibility to have one SVG size that fits all scale factors, if background SVGs are scaled with odd factors. It would really make sense to use only full integers here.

I tried my luck with fixed sizes so that at least this would be a workaround. There also seems no difference between adding "dp" or not to the value, the SVG is scaled either way. So there seems no possibility to use  SVGs for background patterns. Edit: There is one possibility, just add "px" instead of "dp". Normally in mapsforge no unit means px, so I didn't try this before.

Maybe I'm missing something here, but the documentation is a bit scarce about this.
#56
As I try to make my themes completely scalable I converted all patterns to SVG.
I only use sizes like 8/16/32/64/128, those scale well with standard mapsforge at every ppi, as standard uses multiples of 64 for scaling. For Locus I add the "dp" unit.

Most of the patterns are seemless and work well with Locus at 160/320ppi. But with odd multiplicators like 240/480ppi they don't work anymore, see attached screenshots of 240/320ppi.

Same problem applies to Locus internal seems, when SVG patterns are used.

How exactly does "dp" work, and is there a possibility to have seemless SVG patterns that scale with screen density?


Edit - theme for testing is here: http://www.openandromaps.org/wp-content/users/tobias/Elevate4_Locus.zip
#57
Quote from: balloni55 on April 25, 2016, 13:20:30
Quoteand if a border of an area isn't closed, it's not treated by the rendering engine as as an area - so no color and no names.
ok understand, but.....
e.g. area of North Sea and Baltic Sea are blue, where is there the border for rendering?
That's a bit OT: If there is a sea/coast in a map, sea is treated differently - it's rendered below the land area as blue rectangle (that's the border for rendering), then the land area is rendered according to coastline/map boarders on top of sea. On the land area, everything else is is rendered, like lakes etc. Usually the sea and land areas are prepared once for proper rendering and are not updated anymore from current OSM data.
#58
Quote from: michaelbechtold on April 21, 2016, 22:24:10
Just checked: the Elevate 3 themes I have installed are V4 since Sept. last year. So they should be available in any case, right ?
Locus versions of Elevate 3 are version=1 and locus-extended=1 (see <rendertheme> tag). They can only be used with Locus 0.3 mapsforge fork . Standard versions of Elevate 3 are version=4, only those can be used with ML maps.

Quote from: balloni55 on April 23, 2016, 13:21:53
- in the area of country border color of lake is white and not blue e.g. Bodensee/Lake Constance or Genfer See
- name of lake isn´t displayed
The lake isn't probably completely contained in the maps (as country borders cut it), and if a border of an area isn't closed, it's not treated by the rendering engine as as an area - so no color and no names.

Quote from: balloni55 on April 23, 2016, 13:21:53
Question:
what should multilingual map display? - names of towns, POI´s ??

Every OSM name tag which has not just "name=*" (local name), but also "name:XX=*" can be seen, see here.
E.g. "name=München" has "name:EN=Munich", so if you choose standard language, "München" is displayed, if you choose english, "Munich" is displayed. For every name that has no "name:EN=*", the standard/local name is displayed.
It's not limited to towns, but this is the most likely usage.
#59
Other features / Re: Mapsforge 0.5
April 11, 2016, 14:12:18
Quote from: menion on April 11, 2016, 14:01:31So for maps V3, only themes with version="1, 2, 3", for maps V4, themes with version="4".

Hm, that's a bit strict. There's no issue in using V3 maps with V4 themes. Although the numbers differ, they aren't dependent on each other. Mapsforge 0.5 introduced V4 themes, while still producing V3 maps. It would be strange to be able to install V4 themes but not to use them, and will certainly cause support issues.

So if you install and choose a V4 theme switching to standard mapsforge would make sense to me.
#60
Other features / Re: Mapsforge 0.5
April 11, 2016, 13:52:46
That's excellent news, thanks!

Quote from: menion on April 11, 2016, 08:57:36
Locus automatically decide which map renderer use by version of map.
Also by version of map theme?