Menu

Show posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Show posts Menu

Messages - karlchick

#46
Themes - Vector maps / Re: [Theme] OS Map
December 04, 2023, 16:47:00
I'm considering adding some unicode icons to the overlay menus to help visually group similar options together. 

What do you think of the attached example?

TBH, I was struggling to find useful symbols for the lower down options... may change them to colours instead...
#47
Themes - Vector maps / Re: [Theme] Tapiola
December 04, 2023, 01:48:56
Hi Tapio,

I am wondering how in your theme you get icons to appear in the stylemenu?

Attached is comparison of mine and all other themes vs your theme.

Would love to be able to use icons too...

UPDATE, I figured it out, you're using unicodes. So limited to what is built in...
#48
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 22:51:02
Had a busy evening, managed to draft fixes for all the issues reported so far.

I've loaded a draft version with fixes here:

    OS Map v20231203 Draft1.zip

I've not updated the legends or release notes yet, will do that for a proper release.

Changes made are:
- reduced heavy pylons at high zoom levels.
- fixed issues causing Oruxmap to not display many elements correctly.
- added option enabled by default "show symbols earlier" to allow reduced clutter in cities.
- fixed dynamic view of footpath dashes green/black out of sync
- moved surface highlights to below the highways to avoid obscuring the surface texture and street names.

BTW, the issue with Oruxmaps was down to case sensitivity of filenames in theme vs actual filenames. Seems Windows likes to capitalise the first letter by default. Have renamed all files to lowercase now.

Please try out the new draft and I'll all be very grateful of any feedback, thanks in advance.
#49
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 17:20:13
Thank you everyone for feedback and bugs found so far, I very much appreciate it and will work on these to get a fixed release out ASAP. Attached is my fix list so far.
#50
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 17:14:11
Quote from: john_percy on December 03, 2023, 17:07:11When accessible footpaths is off, Landranger doesn't show all the paths that Dynamic does at zooms where the Landranger style is used.
When accessible paths is off, Explorer shows paths as black dashes which are replaced by green dashes when accessible paths is turned on.

This is correct behaviour, Landranger maps only show PROW and not other footpaths. If you select accessible or designated path then what is assumed to be a PROW is widened to include these too, although they will not be highlighted as PROW if they are not designated using designation tag...

Note: Landranger theme uses black dashes for cycleways, bit of a compromise as original OS maps don't show cycleways but if the cycleway is a visible track they are often shown as vague black dashed lines alongside other features...

Hope that's not too confusing...
#51
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 16:46:25
Thanks John, it seems to relate to when "accessible paths" option is used. Found, I made the dashes larger but missed some for this option. It starts to get difficult to spot errors in 14,637 lines of rules!
#52
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 11:58:38
Quote from: twoten on December 03, 2023, 10:38:44This line only appears with the latest version of your theme. It was OK with the previous version.

I've tracked this down to a change to use the darker night cliff texture for 1:50k maps to closer match OS maps. But it seems that Oruxmaps is filling the background of the transparent PNG with black, in the fixed example above I reverted 1:50k to use the day texture and it works.

I will look at the masked areas used in the PNG texture files and see if there is something causing this. Odd that LocusMap doesn't fill in the background for the same PNG image.
#53
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 11:32:08
Quote from: john_percy on December 03, 2023, 09:41:25Do you count designated=foot as a PROW? Should highway=bridleway be recognised as a PROW? Also designated=horse?

In the OS Map theme I use green(25k)/pink(50k) dashes to indicate what could be assumed to be PROW. Ideally this would be based purely on the designation tag and four main values (I still need to work on the other values used for Scotland and IOM).

However, not all PROW are fully mapped yet, so there are additional rules which can be  included using the accessible paths and designated paths options, as described in simplified rule form above. There are quite a few rules used in fact to decide if a path is likely a PROW.

It's the best compromise I have come up with using the data available and also providing OAM maps with similar results.

Highway=bridleway is shown as a green long dashes, but not highlighted as such. I was going to include them in the PROW highlighting but wanted to encourage the use and completion of the designation tag. By only using the designation tag for highlighting, it also allows you to know if a way is a real PROW and not an assumed PROW. Of course, I am assuming that the designation tags are correctly tagged PROW, which is their intended use.

Regarding the pylons/powering, I don't think I changed these in this release. They are designed to mimic the OS map, but do enlarge as zooming in. Thanks for the feedback, I'll consider improvements for the next release.
#54
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 01:47:36
Hi Twoten,

Thank you, you found a bug in the theme. I've fixed it locally and it seems to work on Oruxmaps now, see attached.

I'll update the theme soon with a bug fix release.
#55
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 01:21:51
Quote from: twoten on December 02, 2023, 22:29:09I'm using Great-Britain_oam.osm downloaded from Mapsforge.
I'm viewing the map using Oruxmaps.

Hmm... I've installed Oruxmaps, installed my theme, downloaded great britian map fro OAM and managed to repeat your issue.

I wonder what the issue is... could be my theme, the map, an unsupported rendering engine command...

Attached is a zoomed in view. It is the cliff edge that is wrong. There seems to be the black line in both, but the pattern filled line of cliff texture is solid black in Oruxmaps.

I'm using linesymbol with a rock texture, perhaps linesymbol is not supported in Oruxnaps...? No it works in 25k...
#56
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 01:08:09
Thanks for the feedback John, much appreciated. The PROW only work with LoMap v4 maps, OAM maps do not include the designation tag used.

Regarding the highlights, are you're not seeing anything like the first attached image in LoMap v4 map? Are the paths in your area tagged with designation tag?

Regarding the 1:50k power lines, attached on image 2 is what I see at zoom levels 14, 15, 16 and 18. Is this similar for your?
#57
Themes - Vector maps / Re: [Theme] OS Map
December 03, 2023, 00:49:18
Quote from: john_percy on December 03, 2023, 00:19:53- The legend didn't appear within Locus until I had opened it outside the app first, then it worked. Android 13 strangeness, I think.

I haven't dare update from android 11 so far... I've got my daughter a new phone christmas with A13, perhaps I'll have a sneaky peak and see, then Factory reset...
#58
Themes - Vector maps / Re: [Theme] OS Map
December 02, 2023, 23:46:02
Ooh, I haven't tried oruxmap, I might look into that, perhaps there is something different on the map rendering engine...
#59
Themes - Vector maps / Re: [Theme] OS Map
December 02, 2023, 21:53:23
Ho twoten, thanks for providing feedback. I guess you using OAM map at x15, bur whe I check using OAM great britian at z15 I do not see this, see attached...

I've attached the map details I used, if different to yours, could you let me know which map you are using?

I am also intrigued what map viewer you are using, as it looks different to LocusMap.
#60
Quote from: karlchick on December 02, 2023, 00:59:51... the new PROW highlights are drawn below the highway... I should do this for these highlights too.

Attached is a quick test of doing this, think I like it...