Menu

Show posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Show posts Menu

Messages - karlchick

#16
Themes - Vector maps / Re: [Theme] OS Map
January 17, 2024, 12:26:59
As far as a I know, amenity=bicycle_parking tags are not available in either LoMap or OAM maps.

I suspect the Web-based router planners are using OSM map data directly and so show all available tags on the map rendering.

BTW the red P symbol in my theme represents private parking
#17
Themes - Vector maps / Re: [Theme] OS Map
December 28, 2023, 21:54:36
@lettm, seems you intend to use it as is, would be good if you can let me know if you think it is usable in this form after some field use.

I will fix the bugs we found and area outline issues in the original OS theme, then it will be ready for VTM, if they fix the other issues.

In the short term, it would be quite simple to have a script that converts the released day/night OS theme files to VTM, mostly by multiplying the dash array values by 4.

I did manually tweak the power lines a bit, not very well. I think it possible to redo the power lines using line symbols, maybe....
#18
Themes - Vector maps / Re: [Theme] OS Map
December 28, 2023, 20:58:03
Quote from: Lettm on December 28, 2023, 18:45:43Thank you - that looks really good! this is probably the effect you mention - I'm seeing thick lines for cliffs and a few footpaths.  Ill try and attach an screenshot...

Strange, I don't get that with OAM map.

Are you using a different map?

Did you add the xml theme file into the os map.zip file, in the same directory as the other xml theme files?
#19
Themes - Vector maps / Re: [Theme] OS Map
December 28, 2023, 20:40:12
Quote from: twoten on December 28, 2023, 19:37:03What is the difference and advantage of VTM (when it works)?

Symbols and names rotate with the map, see attached.

I think VTM also supports 3D mapping, like on a satnav... if the app supports it...
#20
Themes - Vector maps / Re: [Theme] OS Map
December 28, 2023, 00:14:02
Had a play with the VTM dash array values, got most of them working-ish (again only 25k).

Finding lack of support for round and square linecaps a pain, and it seems dash array values are not comparable between lines of different widths.

Also, when multiple ways follow the same coordinates, the dash arrays don't always line up, e.g. route on a path.

@lettm, attached is the hacked theme file. If you wish to try it out.
#21
Themes - Vector maps / Re: [Theme] OS Map
December 27, 2023, 20:25:49
I can see the same issues in tapiola and voluntary themes too, dashes are too short, too many symbols shown without priority used, overlapping areas deleted, lack of dy offsets.
#22
Themes - Vector maps / Re: [Theme] OS Map
December 27, 2023, 18:44:45
@lettm, attached is a hacked version of the day time theme file, I only fixed the area commands for 25k option. Saves you doing it all again.

I just added it to the "OS Map.zip" and selected "OS Map Test" from the theme selection.

I'm wondering if the dash array issues can be fixed by emux, otherwise a much more effort way would be to create a MF / VTM overlay option and adjust the sdash array numbers to suit VTM... maybe...
#23
Themes - Vector maps / Re: [Theme] OS Map
December 27, 2023, 17:00:17
OK, managed to figure out what was causing my theme to crash in the VTM viewer, a couple of rules like this (no idea how they ended up like this):

    <rule e="any" k="*" v="*|~">

Fixing these rules fixed the crashing, but I also found many incompatibilities with the VTM viewer:

- area outlines have to be drawn separately using line command.
- dy offsets appear not to work on anything I've used in the theme.
- dash arrays on lines have a different scaling (4x smaller?) and do not seems to work very well as you zoom.
- dash arrays vary with line thickness
- lines are slighter thicker.
- no support for stroke-linecap round or square.
- line images are distorted/stretched.
- areas that overlap of the same tag sources are mutually exclusive and disappear where they overlap.
- priority seems to be ignored for symbols and text.

My theme uses dash arrays and dy offset a lot, making the VTM viewer not very acceptable. See attached screenshot comparing GB OAM map in ORUXMAPS using mapsforge viewer (left) vs VTM viewer (right).

In summary, I would say that VTM viewer for mapsforge themes is not really ready yet.
#24
Themes - Vector maps / Re: [Theme] OS Map
December 23, 2023, 21:21:18
Quote from: Lettm on December 07, 2023, 12:13:46... ORUXMAPS... beta version ... experimental VTM display does not work with your theme.  It used to blue screen completely until their last update, now if it can't load a theme it reverts back to a default theme.  The viewer does work with John Campbell's Voluntary theme.  The viewer is very good - it keeps place names the right way up as you rotate the map. I can't see any error logs so have no idea what the problem is. 

I've downloaded the beta ORUXMAPS and tried VTM, as you say it doesn't work with my theme but does with John's Voluntary theme (which OS Map was originally based on).

I really like the VTM viewer and would like to see it working with my theme. Not sure where to start debugging this. I guess there might be some mapsforge tag attributes not supported by VTM?, or maybe some of my SVG files are not fully compatible tiny SVG...

May take a while to figure out...

Anyone know is there are any tag rules that are not compatible with VTM viewer?
#25
Hi Everyone,

A big thank you to everyone that tried out the recent v20231013 release (it contained a lot of changes I have made over the last 2.75 years!) and thank you everyone for kindly reporting back to me the bugs/issues and things that could be improved further.

I've incorporated the changes and have just updated the sticky "[Theme] OS Map" topic thread with the latest release (see post #1 for updated release notes and details).

I'm hoping I can get this version of the theme into the Locus Map store to make it easier to download and install soon.
#26
Themes - Vector maps / Re: [Theme] OS Map
December 20, 2023, 00:39:49
I've just uploaded the latest release of the OS Map theme (v20231218) which now includes fixes and updates for many issues you all reported to me. A very big thank you to all for reporting your findings, I hope this release will be OK enough to finally release into the Locus Map store, my next task.

Here is a list of the changes in this latest release:
  • Removed residential roads from filled in residential areas at zoom level 12.
  • Removed unused categories and tidied up style menu definitions
  • Added colour icons to style menus to indicate options by colour groups, green=hiking, orange=cycling, purple=mtb, brown=urban, black=roads, white=non-OS.
  • Added option "Show symbols earlier" so you can have less symbol intrusion at Z15 and lower, useful in urban/city areas.
  • Added option "Building names earlier" so you can have more building namers appear earlier from Z16 onwards.
  • Added option "emphasise all sealed roads too" so you can selectively also highlight ALL roads that are sealed, or disable (if you prefer a less distracting urban view).
  • Added footpath names visible from Z16.
  • Changed "surface textures" options to also include all steps, footpaths and bridleways.
  • Changed option "road surface/grade textures" to "surface textures" to be shorter menu entry.
  • Changed option "emphasise road surface/grade textures" to "emphasise surface textures" to be shorter menu entry.
  • Changed size of covered reservoir symbol at Z13/Z14 to be smaller.
  • Changed unclassified roads to appear from Z12 (was Z13).
  • Changed smaller service roads to appear from Z13 (was Z12).
  • Changed 50k pylons to be smaller at high zoom levels.
  • Changed place name priorities to work better.
  • Fixed missing bridges casings at Z13/Z14.
  • Fixed symbol/pattern filenames to be have matching cases in both theme and filing system - enables theme to work correctly with OruxMaps.
#27
Quote from: john_percy on December 17, 2023, 15:42:20But also, l purposely keep the number of options to a minimum and thought that "drive on left/right" choice for just one particular scenario was too much.

Yes, especially as it's two options that should be mutually exclusive.

I have got the two options for cycle lanes. But also use them for placing OS style road numbers alongsode dual carriage ways on the correct side depending on whether left/right hand traffic direction. Otherwise the road numbers appear in the central reservation for one of the conventions.

Also I tweak the symbol for post boxes, left hand drive uses red circles (like a plan view of our red pillar post box) and right hand drive uses square yellow box (like continental post boxes).


But, my OP was concerned with why LoMap and OAM render differently. Not checked the rules with a fine toothed comb yet... maybe over Christmas break I'll find time...
#28
Quote from: john_percy on December 17, 2023, 09:37:20@karlchick
I left it as a hidden option as the mapping was not reliable enough to make it worthwhile.

I tried your change from both to left and it works the same as my theme now.

I'm wondering what aspects of the mapping you found unreliable?

Is it that left/right tagged lanes are relative to the direction the way is drawn in OSM, hence it's dependent on the mapper ensuring the arrow on the way's center is correct? Or something else?

If the direction, I think it makes sense to make this visible in the map rendering so someone can update the OSM definition...

I also agree having not having radio buttons on the stylemenu is a major deficiency in the interface.
#29
I'll try a Locus map weblink for position:

https://web.locusmap.app/loc/51.86898:-2.22724:Cycle%20lanes%20on%20one%20way

Here's the osm link to the way too:

https://www.openstreetmap.org/way/4225982



I wasn't aware of the tag transform documentation, will find and read, thanks.
#30
Not many themes support cycle lanes, my os maps theme and John's Voluntary themes do.

But I've noticed some differences between OAM/LoMap maps and also mine/John's theme when it comes to rendering cycle lanes on one ways highways.

Here is what OSM define for cycle ways:

Dedicated cycle lanes
cycleway=lane is used to tag two-way streets where there are cycle lanes on both sides of the road, or one-way streets where there is a lane operating in the direction of main traffic flow.


In my theme I have options to let the user indicate if they are in a country that drives on the left or right, since the logic of which side a cycle lane should exist on a one-way highway depends on in this.

Wondering @john if you decided not to differentiate for one way highways?

Also wondering if OAM tag transforms cycle lanes differently to LoMap, as there are differences in the results using the same rules...

I guess I'll, have to go through the theme rules with a fine toothed comb to figure out what's going on...