Locus Map - forum

Development => Discussion/New features => Topic started by: fzk on December 05, 2014, 13:48:26

Title: Mapsforge 0.5
Post by: fzk on December 05, 2014, 13:48:26
After a long period of stagnation the mapsforge project is now successful back for over a year. The current release is 0.4, the upcoming release 0.5 is coming soon. Each release has a lot of fixes and new features. Are there any plans to switch from the proprietary Locus mapsforge release 0.3 (?) to the "official" mapsforge release?

Klaus
Title: Re: Mapsforge 0.5
Post by: menion on December 05, 2014, 14:35:08
I have not yet checked what news are in new releases of MapsForge libs, but I expect that lib will still be a slower then improved version I use.
Title: Re: Mapsforge 0.5
Post by: Tobias on December 05, 2014, 15:10:24
It would be great for compatibility reasons. With 0.4 not that much has changed for render themes, but that will be the case for 0.5 which is RC now. It won't be possible to provide all features for Locus then with my Openandromaps themes.

And there are already problems with Locus and maps with mapwriter 0.5, which has major improvements and is used on Openandromaps now.

If mapsforge 0.5 is still slower, it would be nice if your enhancements would be added to the official version, it's LGPL after all.

Best regards,
Tobias

Title: Re: Mapsforge 0.5
Post by: menion on December 05, 2014, 17:19:47
Modified code is available for everybody who wants. Anyway whole code is highly modified for Locus purpose. Because of this, I'll never be able to use official distribution.

Only in case, new version will bring more advanced features, I'll have to spend a few days and add improvements from Locus to new modified version.

About themes - I think, it should be a lot easier, to give me a list of tags that do not work in new Locus and are included in v 0.5, and I'll try to add support also for them to Locus.

And fact that new maps do not work on 100% in latest Locus is a big mystery for me. Format remains same.
Title: Re: Mapsforge 0.5
Post by: Tobias on December 05, 2014, 22:50:42
Modified code is available for everybody who wants. Anyway whole code is highly modified for Locus purpose. Because of this, I'll never be able to use official distribution.
OK, my thought was if your improvements would be added, it would be usable for you too and easier to update.

Mapsforge is pretty active these days and there are already plans for 0.6:
https://groups.google.com/forum/#!topic/mapsforge-dev/qgVmqSXiwKM
Performance is very high on the list, so maybe you could share there what you did for speed up.

Quote
Only in case, new version will bring more advanced features, I'll have to spend a few days and add improvements from Locus to new modified version.

Here's the changelog:
https://github.com/mapsforge/mapsforge/blob/master/docs/Changelog.md (https://github.com/mapsforge/mapsforge/blob/master/docs/Changelog.md)
The biggest changes in 0.4 for end users would be:
- Support for device screen scaling (maps tiles have different sizes according to device dpi)
- Support for SVG files as map icons (what Locus already had)

Quote
About themes - I think, it should be a lot easier, to give me a list of tags that do not work in new Locus and are included in v 0.5, and I'll try to add support also for them to Locus.

That's one major change of 0.5, and it would be great if it would be compatible. Creating different theme versions could be a major headache, it's already a minor ;-)

Everthing below Rendertheme Version 4 is new:
https://github.com/mapsforge/mapsforge/blob/master/docs/Rendertheme.md
https://github.com/mapsforge/mapsforge/blob/master/mapsforge-map/src/main/resources/renderTheme-v4.xsd
priority and display (force-draw?) are already in Locus, but I'm not sure if it has the same values and function.
There are smaller underlying changes too, e.g. dy works now for symbols/captions on ways too.

Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: Emux on December 14, 2014, 10:29:54
Modified code is available for everybody who wants.

Hi Menion,

I'm Emux one of the two Mapsforge maintainers (along with Ludwig).

We would be interested in Mapsforge modified code, how can this be accessible?

The tag matching bug seems to be solved in your version.
And any possible improvements (specially speed) would be welcomed.

I understand you have your own changes,
but all possible compatibility would certainly benefit the community.

Best regards.
Title: Re: Mapsforge 0.5
Post by: menion on December 14, 2014, 10:45:58
Hi Emux,

sure, no problem. Check attachment with current version.

I've adapted two years old MapsForge lib to Locus as much as possible, so it's not well compatible with current version. That's main reason why I do not contribute back. MapsForge will always try to be as universal as possible and I will always need something extra :).

Main changes in lib that may interest you:
- support for unlimited maps at once
- support for multi-thread (only rendering, not data mining)
- a lot of rewrote in rule checker, where lib firstly create optimized theme with only required rules
- checking of tags based on integers and not on strings
- hmm and probably another 100+ optimizations

Good luck
Title: Re: Mapsforge 0.5
Post by: Emux on December 14, 2014, 11:07:23
Thanks Menion!

We should certainly check the code.
Title: Re: Mapsforge 0.5
Post by: menion on December 14, 2014, 11:38:55
sure, no problem. If you will need some explanation to some changes, let me know.
Title: Re: Mapsforge 0.5
Post by: Tobias on February 15, 2015, 23:04:01
About themes - I think, it should be a lot easier, to give me a list of tags that do not work in new Locus and are included in v 0.5, and I'll try to add support also for them to Locus.

Hi Menion,
do you still intend to add support for mapsforge 0.5 themes?
At the moment I'm working on a new version based on mapsforge 0.5 possibilities of the Elevate theme for OpenAndroMaps, which of course doesn't work with Locus for now. Maybe it's good for testing:
http://www.openandromaps.org/en/oam-forums/topic/elevate-updates-and-test-versions-news#post-3858 (http://www.openandromaps.org/en/oam-forums/topic/elevate-updates-and-test-versions-news#post-3858)
Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: menion on February 20, 2015, 18:24:17
Hi Tobias,

sorry for a late response.

Yes, I still think that support of major changes in 0.5 version should be useful not just for you (as a theme creator). So why not. Anyway I'll need some help. As this task is a longer one, I wants to do it step by step. So some important things first.

Best should be, if you should make just one theme for all apps right? Them may you write first (maybe first two) major things I should examine in new XML file and which you really desperately needs? Thanks
Title: Re: Mapsforge 0.5
Post by: jusc on February 20, 2015, 20:09:03
And what does it mean for all other themes?

Sent from my GT-N7100 using Forum Fiend v1.3.2.
Title: Re: Mapsforge 0.5
Post by: menion on February 20, 2015, 20:25:46
I think ... nothing :). All themes that works with Locus now, will stay in all cases 100% compatible. I'll take care of it, don't worry.
Title: Re: Mapsforge 0.5
Post by: Tobias on February 20, 2015, 21:14:17
Thanks for your response, I'm glad you're still into it.

Best should be, if you should make just one theme for all apps right? Them may you write first (maybe first two) major things I should examine in new XML file and which you really desperately needs? Thanks

You're right, there is one major obstacle which makes it nearly impossible to convert 0.5 themes to Locus: stylemenus and categories with overlays, as described here:
https://github.com/mapsforge/mapsforge/blob/master/docs/Rendertheme.md#stylemenus

It opens up a lot of possibilities, so I made intensive usage of it in my new previews. But it needs a user interface with mapstyle and layer selection.
Other new tags may possibly be converted by a script as a workaround for the time being.

And what does it mean for all other themes?

Other apps which support Rendertheme V4 still support older themes (except Locus extensions of course), so backward compatibility is no problem.

Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: menion on February 21, 2015, 15:55:45
I was worried you'll need this :) ... hmm it will be task on a longer nights.
Title: Re: Mapsforge 0.5
Post by: Tobias on February 22, 2015, 20:28:09
I was worried you'll need this :) ... hmm it will be task on a longer nights.
I am worried to hear this ;-)
But it's really additional value to have this, I got really good feedback from users from the first previews for having the option to (de)activate different parts of the map (symbols, routes, captions etc.).
Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: Oliver Naumann on April 05, 2015, 11:25:23
This sounds like Exciting News! Really looking forward to seeing these improvements and new features of Tobias new Map Themes in Locus. Is there a feature request in helpdesk I can upvote?

thanks!
Title: Re: Mapsforge 0.5
Post by: jajaballard on April 07, 2015, 09:01:03
Yes, since I heavily use the OpenAndroMaps with the elevate themes, I would support getting the new Mapsforge features implemented in Lucus. Which is btw. the best navi app for my MTB-tours :-)
Title: Re: Mapsforge 0.5
Post by: menion on April 07, 2015, 09:37:59
Unfortunately guys, we do not consider this as most important feature now, and because of lack of time, do not expect this task implemented within a next weeks, sorry.
Title: Re: Mapsforge 0.5
Post by: jusc on April 07, 2015, 10:16:17
Yes, since I heavily use the OpenAndroMaps with the elevate themes, I would support getting the new Mapsforge features implemented in Lucus. Which is btw. the best navi app for my MTB-tours :-)
Locus, of course  ;D, but you should choose a bicycle theme.
To use only one theme for all (city/hike/cycle) and to have
Quote
  the option to (de)activate different parts of the map (symbols, routes, captions etc.).
you can use Cruiser Beta app and Atlas (for Windows development) both developed by Emux or Oruxmap latest beta.
I my eyes these are good for theme developers, because you can combine all features together in one theme.
I don´t know if users really change or (de)activate often symbols or captions.
Changing the whole theme with Locus is not much more work for users.  ;)
 



Title: Re: Mapsforge 0.5
Post by: menion on April 07, 2015, 10:30:49
Do you know about feature that we use for our own internal themes?

It's not publicly promoted, but it should work quite well. Hard to say if UI will work as expected, but this should be easy to improve when will be interest. Check fresh uploaded themes for Locus: http://docs.locusmap.eu/doku.php?id=manual:map_tools:vector_maps_content&#internal_themes (download is at bottom)

There is extra parameter "style" at every rule, where you may define in which style this rule is used (no style parameter = always used). Like:

Code: [Select]
<rule e="node" k="highway" v="motorway_junction" style="car|foot" >
After you tap on theme with more then one style, Locus should offer which style you wants to use.
Title: Re: Mapsforge 0.5
Post by: jusc on April 07, 2015, 13:30:41
@menion,
thanks for this hint,
1. but how can I switch from p. e. cycle to hike? There is only one xml file?
I loaded the complete theme as an external theme (only renamed it to "Internal"), but tapping on it doesn´t offer any style (cyty, hike or...). For me it looks only as one theme.

2. tag-mapping.zip wasn´t found at your shared link.
Title: Re: Mapsforge 0.5
Post by: menion on April 07, 2015, 13:32:21
1. hmm it should :). So it looks I offer feature that do not work :). Sorry, I'll fix ...

2. "not found", thanks, Peter is going to fix it now
Title: Re: Mapsforge 0.5
Post by: Tobias on April 07, 2015, 22:40:57
I don´t know if users really change or (de)activate often symbols or captions.

Me neither, but I had often requests that those symbols/captions are more important than others and vice versa, so now one can choose which to show (it helps a lot with symbol/caption elimination, too). I usually assume that people know better than me what they want so having the option to get closer to it isn't hurting.
Probably most of the time users set their overlays only once, but there are other cases:
I sometimes use the routes in the maps for hiking/cycling and now can switch on strong overlays for those, and sometimes I don't and can deactivate routes altogether. Or I usually don't need to see hospitals in a city map, but in emergency I only want to see those (OK, there are other solutions for that in Locus now).

Changing the whole theme with Locus is not much more work for users.  ;)
Depends on the user ;-)

Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: john_percy on April 17, 2015, 00:39:34
The attached theme demonstrates the style feature in the new beta version. Download and copy to your Locus MapsVector folder, then select the Voluntary UK beta theme. You are then presented with a choice between Hiking, Cycle or Road.
The variations are currently limited to switching on or off display of hiking or cycling routes. They work both with maps from OpenAndroMaps and Locus Store with some added functionality with OpenAndoMaps maps.

(http://s12.postimg.org/kcom5dyyh/Screenshot_2015_04_16_23_37_12.jpg) (http://postimg.org/image/kcom5dyyh/)
Title: Re: Mapsforge 0.5
Post by: jusc on April 17, 2015, 11:03:18
1. hmm it should :). So it looks I offer feature that do not work :). Sorry, I'll fix ...

Works now, thank you.
But one question, if I want to change the theme with "quick settings", all actually used themes are marked with red color., except your example theme if it is in use.
Title: Re: Mapsforge 0.5
Post by: menion on April 17, 2015, 12:26:36
Good point, thanks.

Small bonus to next version, John, try to add following files to your directory, so it should look like this:

(http://s17.postimg.org/vbgfcumaj/Screen_Shot_2015_04_17_at_12_25_52.jpg) (http://postimg.org/image/vbgfcumaj/)

;)
Title: Re: Mapsforge 0.5
Post by: john_percy on April 17, 2015, 13:18:15
Presumably only partially implemented at present? I can get an image for the overall theme, but not for the styles.
(http://s7.postimg.org/ed5p16cyv/Screenshot_2015_04_17_12_06_00.jpg) (http://postimg.org/image/ed5p16cyv/)
Title: Re: Mapsforge 0.5
Post by: menion on April 17, 2015, 13:37:52
small bonus to next version

jop. Image for theme itself is in Locus for very very long time. Icon for this sub-theme will work in next version
Title: Re: Mapsforge 0.5
Post by: john_percy on April 20, 2015, 22:06:47
(http://s12.postimg.org/kcom5dyyh/Screenshot_2015_04_16_23_37_12.jpg) (http://postimg.org/image/kcom5dyyh/)
Icons for theme and styles now appear (good), current theme is now coloured red (good). How about colouring current style red as well, please?
(http://s27.postimg.org/qizzkmrsf/Screenshot_2015_04_20_18_58_16.jpg) (http://postimg.org/image/qizzkmrsf/)
Illustration is from Voluntary UK theme, see http://forum.locusmap.eu/index.php?topic=2915.msg19296#msg19296
Title: Re: Mapsforge 0.5
Post by: menion on April 20, 2015, 22:51:47
I was sure I did this feature also. But .. not, sorry. So will be in next version, thank you!
Title: Re: Mapsforge 0.5
Post by: jusc on April 21, 2015, 08:47:50
Thank you.
I played ab bit with this new "style" feature (new at least for me)
It makes it much easier to create a (one) theme for different applications.
Title: Re: Mapsforge 0.5
Post by: menion on April 21, 2015, 09:00:14
Good to hear it. Unfortunately such feature is not available in other app, just in Locus.

We created it for our internal usage almost year ago. Because Locus contains five different internal themes, Peter had to edit every single file due to some small changes, so we created this. Unfortunately MapsForge comes later with own, I think a more complicated solution, which is not supported in Locus yet as you know. Anyway for Locus users, it works quite well I believe.
Title: Re: Mapsforge 0.5
Post by: slarti76 on May 06, 2015, 09:01:21
Wanted to try this out, but the link above (http://docs.locusmap.eu/doku.php?id=manual:map_tools:vector_maps_content&#internal_themes) doesn't work?! Also trying it manually (Advanced -> Advanced Map Tools -> Locus Map Theming) gives error message "This topic does not exist yet".
Title: Re: Mapsforge 0.5
Post by: Michal on May 06, 2015, 09:41:03
Wanted to try this out, but the link above (http://docs.locusmap.eu/doku.php?id=manual:map_tools:vector_maps_content&#internal_themes) doesn't work?! Also trying it manually (Advanced -> Advanced Map Tools -> Locus Map Theming) gives error message "This topic does not exist yet".
Hi, quite a lot of articles from the old manual (all advanced) haven't been repaired and transferred to the new version. We're working on it. If you want anything from the old version, just add "_old" behind "docs" in URL. The manual is being built above the wiki platform, that's why you get "This topic does not exist yet" prompt.
Title: Re: Mapsforge 0.5
Post by: slarti76 on May 06, 2015, 09:55:28
Thx a lot! Now I'll have to try this out, from the discussion I'm not really sure yet what this feature offers...
Title: Re: Mapsforge 0.5
Post by: slarti76 on May 06, 2015, 12:28:15
OK, yeah, tried it and works fine. Now if there only were a way to hide the 5 internal themes so to get a cleaner quick-switch dialog (got several OAM themes plus the V-Scale2 Pure...). Is that planned?
Title: Re: Mapsforge 0.5
Post by: menion on May 06, 2015, 12:42:23
nope :)
Title: Re: Mapsforge 0.5
Post by: jusc on May 06, 2015, 14:22:22
OK, yeah, tried it and works fine. Now if there only were a way to hide the 5 internal themes so to get a cleaner quick-switch dialog (got several OAM themes plus the V-Scale2 Pure...). Is that planned?

@menion,

but there is already a solution with "style=" switch in themes, as John has already shown, or?
I´m working on one Volatile/VScale version with several styles for my own (at least at the moment).
Or did I missunderstood?
Title: Re: Mapsforge 0.5
Post by: john_percy on May 06, 2015, 14:36:04
I don't think that is the point really. If Menion wanted users to turn off display of the internal themes, I'm sure he could do it! But he says "Nope". And we say "Fair enough".
Title: Re: Mapsforge 0.5
Post by: menion on May 06, 2015, 14:53:55
Thanks John.

Not sure if I understand you @jusc. If I understand correctly @slarti76, he wants to remove possibility to display five internal themes for vector maps, right? And on this I say "nope", as I see no serious reason for this. I expect that common users will be using in worst case just a few external themes, not ten or more. Only creators of themes probably has more versions, but it is a special case.
Title: Re: Mapsforge 0.5
Post by: slarti76 on May 06, 2015, 15:13:21
Menion understood me correctly. And thinking about it again, I think he's right: It's not that big deal. I prefer the internal theme with switching dialog, but this is only "proof-of-concept", as the user has to download the theme file manually.
I just hope that other theme developers will support the Locus solution soon. However, I'm not very optimistic about the Elevate themes, as the developer already implemented MapForge 0.5, and I'm not betting on them to support two different solutions at the same time...
Title: Re: Mapsforge 0.5
Post by: slarti76 on May 06, 2015, 15:21:58
I should probably add that I only think the style selection is good as it it. The whole MapsForge 0.5 concept of overlays sounds pretty great and it would really love to see something like that in Locus, at least the ability to choose what POIs are shown as part of the map.
Related discussions:
http://help.locusmap.eu/topic/how-to-choose-poi%C2%B4s-offline-db-poi
http://forum.locusmap.eu/index.php?topic=4459.0
Title: Re: Mapsforge 0.5
Post by: john_percy on May 06, 2015, 16:00:33
I've thought several times about implementing MapsForge 0.5 in my theme (not for Locus, of course). Not only do I find it daunting, but the end result seems to be far too many choices for the user. Too many choices are worse than not enough, as they result in paralysis! Much better to have a few well thought out options in my opinion.
Title: Re: Mapsforge 0.5
Post by: menion on May 06, 2015, 16:04:18
Too many choices are worse than not enough, as they result in paralysis! Much better to have a few well thought out options in my opinion.
That's what I found too after few years of creating Locus. And also reason why do I not hurry with MapsForge 0.5 system ...
Title: Re: Mapsforge 0.5
Post by: chbla on May 06, 2015, 16:07:39
Well that's just a matter of abstraction. You can always separate things into default and advanced mode.
For me, the benefits outweight simplicity.
Title: Re: Mapsforge 0.5
Post by: Tobias on May 06, 2015, 20:39:38
I just hope that other theme developers will support the Locus solution soon. However, I'm not very optimistic about the Elevate themes, as the developer already implemented MapForge 0.5, and I'm not betting on them to support two different solutions at the same time...

You're right, at the moment it seems not very reasonable.
I first thought about adapting Locus styles, too, but then I would have three different versions to maintain, as there are other apps that still require regular 0.3 themes. Adding only Locus styles wouldn't be different to the variations I developed with several xml files, which are generated out of one base theme file. The only advantage would be to have only two files instead of four, as Elements can't be made in the same file.

I still hope that one day it will be easier again :-)

Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: john_percy on May 06, 2015, 21:27:04
@Tobias: No such word as can't!
Maybe not efficiently or not without unacceptable overheads, but it could be done, I'm sure. :)
Title: Re: Mapsforge 0.5
Post by: Tobias on May 06, 2015, 21:41:17
@John: You're right, can't is wrong, it can be done, but the costs would be way out of proportion of the benefits. I'd invest the time better in a Locus conversion of Elevate 3 :-)
Title: Re: Mapsforge 0.5
Post by: Tobias on May 21, 2015, 21:50:24
I just hope that other theme developers will support the Locus solution soon. However, I'm not very optimistic about the Elevate themes, as the developer already implemented MapForge 0.5, and I'm not betting on them to support two different solutions at the same time...

Good news for you, I made a script which converts Elevate 3 with mapsforge 0.5 tags to Locus, with style switcher. Works quite well, only switchable layers had to be removed and some other stuff and will be released soon. The last big problems I have are with SVG icons and Locus, probably the release will be only with PNGs.

@menion - there are strange behaviours with some icons, it's probably the SVG render engine. Some tiles aren't even rendered because of that.
The icons work fine with the one mapsforge 0.5 uses: https://code.google.com/p/androidsvg/
The former one, https://code.google.com/p/svg-android/, was replaced because of similar issues. I attached a comparison with a PNG version.

(http://s11.postimg.org/cgh3atlcv/locus_svg.jpg) (http://postimg.org/image/cgh3atlcv/)
Title: Re: Mapsforge 0.5
Post by: menion on May 21, 2015, 22:02:53
May You give me link on theme and map I may use for test? Thanks
Title: Re: Mapsforge 0.5
Post by: Tobias on May 21, 2015, 22:25:04
May You give me link on theme and map I may use for test? Thanks
Sure: http://www.eartrumpet.net/temp/Elevate3_Locus_SVG.zip
One thing I found - I converted most contours to shapes to make it possible to have white outlines. Maybe the shapes of the supermarket basket etc. are a bit too complex now.
Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: menion on May 22, 2015, 07:05:13
Thanks Tobias, I've changed SVG libraries and not seems to correctly parse all icons. I'll test it now during morning this change with Petr and if all will be OK, we will publish new version of Locus on Google Play today. So there should be no need to invest extra work to some PNG icons I hope.
Title: Re: Mapsforge 0.5
Post by: Tobias on May 22, 2015, 09:43:45
Thanks a lot, that was very fast.
Thanks Tobias, I've changed SVG libraries and not seems to correctly parse all icons.
I hope you mean "now seems to correctly parse all icons."  :)
Title: Re: Mapsforge 0.5
Post by: slarti76 on May 22, 2015, 10:03:16
Thank you guys, really great that you could "marry" the new Elevate themes with Locus. Looking forward to trying that out.
Title: Re: Mapsforge 0.5
Post by: menion on May 22, 2015, 10:28:20
@Tobias: hehe, yes, "now" is correct word :)
Title: Re: Mapsforge 0.5
Post by: menion on May 22, 2015, 12:01:41
Hmm unfortunately I have to revert new androidsvg lirbary and return back to previously used. New library cause similar issue you see with your own themes, but with our own themes. So seems that one or second lib has some issues with certain features of SVG files.

So we should test it and fix it during next days, but not a few hours before I wants to publish a new version. Thanks for understanding,
Title: Re: Mapsforge 0.5
Post by: john_percy on May 22, 2015, 12:34:53
I came across some of the limitations myself when working on svg files for Locus.
I have just now edited Tobias's s_supermarket.svg in Inkscape as a test. I split the two grouped layers (Ctrl-Shift-G), then ran simplify (Ctrl-L) on each path once before saving. After running SVGClean on the file, I uploaded it and it worked in Locus.
Title: Re: Mapsforge 0.5
Post by: Tobias on May 22, 2015, 17:20:59
So we should test it and fix it during next days, but not a few hours before I wants to publish a new version. Thanks for understanding,

No problem, too bad that there isn't one solution for all ;-)

I have just now edited Tobias's s_supermarket.svg in Inkscape as a test. I split the two grouped layers (Ctrl-Shift-G), then ran simplify (Ctrl-L) on each path once before saving. After running SVGClean on the file, I uploaded it and it worked in Locus.

Thanks John, I tried several things with Inkscape, but not simplify - would have been too easy ;-) That solves some problems. Just have to check now all symbols :-/
Seems like the library gets hickups with too many nodes.
Title: Re: Mapsforge 0.5
Post by: menion on May 22, 2015, 21:23:41
Fine so current SVG in Locus works for Locus themes, but not for some icons from you. Hmm, second SVG has opposite effect.

I'm now testing your icons to check, what is wrong, and seems they are missing width and height parameters.

Nevermind, I've fixed this in SVG parser in Locus, so it will work in next 3.9.1 version ;).
Title: Re: Mapsforge 0.5
Post by: john_percy on May 22, 2015, 21:59:15
I'll be more than happy if that has solved it but I'm somewhat sceptical. As far as I could see, it was the complexity of symbols that caused them to fail in Locus, as in my example above.
Title: Re: Mapsforge 0.5
Post by: menion on May 22, 2015, 22:28:18
Give me svg you are worry about and I'll try to make it work. SVG parser is no more mystery for me ;)
Title: Re: Mapsforge 0.5
Post by: Tobias on May 23, 2015, 09:17:22
I'm now testing your icons to check, what is wrong, and seems they are missing width and height parameters.

I found that too, but there are other issues. Not only complexity (which isn't always fixable with simplify, and some even more complex svgs have no issues), sometimes a missing segment between nodes, and sometimes I have no clue - and have to redraw some parts.

Maybe the problem is with Inkscape vs. Illustrator - all Inscape SVGs render fine with mapsforge 0.5, even complex ones and with missing segments. Locus internal theme SVGs are exported with Illustrator as far as I can see.

Even very simple SVGs are not correctly rendered - example attached. Just a filled blue circle with a grey border, but in Locus it's rendered with a horizontal line. My solution here is to make two circles, grey below, blue above. So yes, it can be solved, but the library seems very picky.
Title: Re: Mapsforge 0.5
Post by: john_percy on May 23, 2015, 10:11:45
When I open Tobias's s_trainstation_lz.svg (from post above) in Inkscape and click on the object, the status bar says "Path 2 nodes in root", but when I use the node tool, there are four nodes. Is that not odd?
After using Simplify, the object tool reads "Path 4 nodes in root". The saved file renders fine in Locus.
I agree however with Tobias that "Simplify" does not solve all the problems with the Locus renderer, even using SVGClean as well.
I notice though that some of Tobias's files won't load into Inkscape (s_kindergarten.svg for example).
Title: Re: Mapsforge 0.5
Post by: menion on May 23, 2015, 10:58:06
I never used Inkspace, I use now only offical docs for SVG to understand it's format http://www.w3.org/TR/SVG/ .

Anyway @Tobias, file rendering (circle) fixed. Who is next ;).
Title: Re: Mapsforge 0.5
Post by: Tobias on May 23, 2015, 11:07:48
When I open Tobias's s_trainstation_lz.svg (from post above) in Inkscape and click on the object, the status bar says "Path 2 nodes in root", but when I use the node tool, there are four nodes. Is that not odd?
After using Simplify, the object tool reads "Path 4 nodes in root". The saved file renders fine in Locus.
Odd indeed. I made that with Inkscape, so I'm puzzled that it can fix itself by simplify. Seems like simplify also checks for oddities.
Quote
I notice though that some of Tobias's files won't load into Inkscape (s_kindergarten.svg for example).
That's because that was work in progress when I uploaded them and not the source files, I was just testing some SVG clean options if that would help with Locus. Haven't found the right ones yet, that's why I posted here.

I never used Inkspace, I use now only offical docs for SVG to understand it's format http://www.w3.org/TR/SVG/ .

Anyway @Tobias, file rendering (circle) fixed. Who is next ;).
Thanks, but maybe it's better if I check every icon that renders wrong and try to fix it. It's probably faster that way, and I'm already at it.
Title: Re: Mapsforge 0.5
Post by: menion on May 23, 2015, 22:31:51
Hmm generally, this is a bad solution. Solving issues in SVG files, that on other places works correctly, isn't useful solution. Soon or later, you or anyone other, will be stuck on same issue. Best and only solution, is to fix this in Locus! My work, not your ...

So to your compare .. all icons from "ele_res_svg" directory. Old (at moring) and now (after few hours) ;)


(http://s29.postimg.org/avhec7fw3/test_orig.jpg) (http://postimg.org/image/avhec7fw3/)

(http://s16.postimg.org/hretcmu8h/test_new.jpg) (http://postimg.org/image/hretcmu8h/)

EDIT: ah, found small issue in corner of "vulcano". Fixed also.
Title: Re: Mapsforge 0.5
Post by: john_percy on May 24, 2015, 00:49:00
Looking at this carefully, funicular, cable car, gondola, fountain, nuclear power, and corners of peak and peak cross still need attention, but otherwise great. Attraction, train station, tram stop should not have a black outline, helipad is not quite right.
;-)
Title: Re: Mapsforge 0.5
Post by: Tobias on May 24, 2015, 08:08:01
Hmm generally, this is a bad solution. Solving issues in SVG files, that on other places works correctly, isn't useful solution. Soon or later, you or anyone other, will be stuck on same issue. Best and only solution, is to fix this in Locus!

Right, that's why I proposed the different library... haven't thought that it would be so complicated though.
But I also like the idea of having simple and clean SVGs, so maybe that's my personal challenge ;-).

As I got them from various sources, there are various issues. One I introduced myself when I used "convert stroke to path" in Inkscape to make outline contours possible; this sometimes introduces two nodes on the same spot (which can sometimes be solves with simplify), which caused many of the rendering issues. But this seems to be solved.

But many thanks, saves me some trouble and I'm looking forward to the next update!

BTW - I haven't found anything about how "priority" works in Locus themes, so I just kept values from mapsforge 0.5 for now - only integers, negative values have the lowest priority, positive values the highest. At the moment no issues, but does that do the job?

Title: Re: Mapsforge 0.5
Post by: menion on May 25, 2015, 08:27:36
Hmm thanks mainly John for testing.

I have a problems with "s_cable_car.svg" file. Three small windows are drawn as "path" where only defined parameter is opacity. But in that moment, background is already completely black and I do not understand why web browser draw these windows as grey. Any idea?
Title: Re: Mapsforge 0.5
Post by: Tobias on May 25, 2015, 08:40:13
Hmm thanks mainly John for testing.

I have a problems with "s_cable_car.svg" file. Three small windows are drawn as "path" where only defined parameter is opacity. But in that moment, background is already completely black and I do not understand why web browser draw these windows as grey. Any idea?

That's a result of SVG Cleaner which removes not necessary tags etc. It's probably this:
Standard value for fill is fill="#000000", so with the option in SVG Cleaner to remove attributes with standard values, this is removed. The Locus SVG renderer still assumes this value, but doesn't use opacity which is still defined. Other renderers use opacity also on not explicitly defined standard values.
Title: Re: Mapsforge 0.5
Post by: menion on May 25, 2015, 10:29:22
Nono, it is not this case.

Locus correctly assume black as default color and apply a opacity on this default black color.

Anyway what is usage of black color, when background on which these windows (with transparent black color) is already fully black


Ah back. Before this semitransparent black is draw, there is also drawn a white background. I missed this. Fine ... so next try to fix it ...

EDIT: fixed

If you find any other icon incorrectly rendered, write me it's name. Of if anyone will wants to check if any SVG files are correctly rendered, just give me a directory with SVG files and I'll render same images directly over Locus.

(http://s1.postimg.org/jedf5zd2z/test.jpg) (http://postimg.org/image/jedf5zd2z/)
Title: Re: Mapsforge 0.5
Post by: jusc on May 25, 2015, 12:23:27

If you find any other icon incorrectly rendered, write me it's name. Of if anyone will wants to check if any SVG files are correctly rendered, just give me a directory with SVG files and I'll render same images directly over Locus.

Can you please try this one?
Title: Re: Mapsforge 0.5
Post by: menion on May 25, 2015, 13:19:36
Looks good


(http://s28.postimg.org/aofo54mq1/device_2015_05_25_131821.jpg) (http://postimg.org/image/aofo54mq1/)
Title: Re: Mapsforge 0.5
Post by: john_percy on May 26, 2015, 10:46:50
Train station and tram stop still have an incorrect black outline and fountain is also still wrong. The problem with fountain is that the right hand side of the drawing is a clone of the left hand side. I don't know if clones are allowed in simple svg.
Title: Re: Mapsforge 0.5
Post by: menion on May 26, 2015, 17:56:49
Thanks John, it is going to be more and more complicated. Train station and tram stop fixed. Anyway fountain is even more complicated and require some more time to implement support for this (anyway it is possible).

But, if it is only this one icon, then I suggest to recreate it without using of this reversed style. Is it possible?
Title: Re: Mapsforge 0.5
Post by: john_percy on May 26, 2015, 18:38:16
Good progress! It's Tobias' icon really. In my version, I deleted the cloned part and duplicated the left hand side instead to get it to work with Locus. However Tobias added a transparent white outline which I hadn't previously but now have (see attached).
Title: Re: Mapsforge 0.5
Post by: Tobias on May 26, 2015, 20:36:21
I also recreated it, as well as all other weird stuff - thanks for the overview, Menion! And congrats on improving the library.
The sources weren't probably made to be used as is (as there was also lots of unnecessary tags included), so it was a good reason to make all as clean and simple as possible.

@menion: I asked above about the priority tag, does it work as in mapsforge 0.5 (only integers, negative values have the lowest priority, positive values the highest)?
Title: Re: Mapsforge 0.5
Post by: Tobias on May 28, 2015, 22:15:11
The new converted version of Elevate 3 for Locus has been released, thanks everyone for the help:
http://www.openandromaps.org/en/legend/elevate-mountain-hike-theme

One thing I realized that is fixed in mapsforge 0.5 and not yet in Locus:
dy doesn't work for POIs which are marked on areas/ways. For example if I have an alpine hut like this:
http://www.openstreetmap.org/way/38173874
Without dy I can only show a symbol or a caption, not both.

This works fine now with mapsforge 0.5, so I removed all workarounds for showing captions for POIs on ways at very high zoom levels. This was maybe a bit premature, as now some areas are clustered with captions without symbols in Locus. But maybe this is a feature of mapsforge 0.5 which can be easier implemented and benefit the rendering of the maps in general?
Title: Re: Mapsforge 0.5
Post by: menion on June 02, 2015, 20:43:31
Hello Tobias,

hmm priorities ... do not know if they works in Locus, I'm worried that they don't. I've anyway made a first biggest step during last few previous days ...

Follow my steps:
1) add theme for last MapsForge library to Locus/mapsVector/_themes directory
2) select this theme in Locus (keep in mind this: http://forum.locusmap.eu/index.php?topic=4601.msg37265#msg37265) - btw: are you using Locus as a common user or just rarely because of creating themes?
3) is theme working for you? If so, fine
4) tap on selected theme once more ;).

Testing feature, should works fine anyway. I wanted to test this on OruxMaps app, but I wasn't able to find some options to change content of active theme, hmm, quite confusing app for me when I never worked with it :).
Title: Re: Mapsforge 0.5
Post by: Tobias on June 03, 2015, 22:19:49
Hello Tobias,

hmm priorities ... do not know if they works in Locus, I'm worried that they don't.
Oh, I thought you had them in your extension as priority is mentioned here:
http://docs.locusmap.eu/doku.php?id=manual:advanced:map_tools:theming
At least it shows no problems if I leave priority values as they are in the mapsforge 0.5 theme.

Quote
I've anyway made a first biggest step during last few previous days ...

Follow my steps:
1) add theme for last MapsForge library to Locus/mapsVector/_themes directory
2) select this theme in Locus (keep in mind this: http://forum.locusmap.eu/index.php?topic=4601.msg37265#msg37265) - btw: are you using Locus as a common user or just rarely because of creating themes?
3) is theme working for you? If so, fine
4) tap on selected theme once more ;).
Congratulations, it works :-). At the moment I have very little time at hand but will test it more ASAP.
Two things I noticed: it makes sense to directly open the mapstyle/overlay menu, the same way when an external theme with Locus styles is opened. And if I change overlays for one mapstyle, they are changed for all mapstyles; this shouldn't happen, as my overlays have different id's for every mapstyle.

You're right, I'm not really an active Locus user as I've started with OruxMaps five years ago and am so used to it. But as I design the advanced themes for Openandromaps and we have lots of Locus users I try to fill their needs as well, so I'm here and have been using Locus a lot too :-)

Quote
Testing feature, should works fine anyway. I wanted to test this on OruxMaps app, but I wasn't able to find some options to change content of active theme, hmm, quite confusing app for me when I never worked with it :).
Yes, very different UI philosophies. You have to use the beta version as mapsforge 0.5 isn't in the playstore version yet: http://www.oruxmaps.com/foro/viewtopic.php?f=4&t=2560
Then hit the map button in the top row, "mapsforge theme" chooses the theme, "tweak mapsforge theme" changes mapstyle and overlays.
Title: Re: Mapsforge 0.5
Post by: menion on June 05, 2015, 11:55:57
I discuss "priorities" with Petr and he confirmed that we tried this system to make labeling better, but it still do not work as we wanted. System was anyway left in Locus. But really, do not expect some better results in Locus.

Theme switcher - directly open a settings is not exactly what I think it is wanted. I'll anyway do some more UI improvements here, so it will evolve over time.

Issue with changing styles ... weird. Should not happen, I'll check it, thanks.

And Orux - ah, it needs some beta. Then it's wasting of time for me as I only wanted to see this system working to better understand what you and users expect. In the end, I did it by myself.
Title: Re: Mapsforge 0.5
Post by: Tobias on June 07, 2015, 15:45:47
I discuss "priorities" with Petr and he confirmed that we tried this system to make labeling better, but it still do not work as we wanted. System was anyway left in Locus. But really, do not expect some better results in Locus.

Thanks for the information. Priority is really an improvement with mapsforge 0.5, label/symbol elimination can now be controlled pretty well. Maybe there's some code you can use.

Quote
Theme switcher - directly open a settings is not exactly what I think it is wanted. I'll anyway do some more UI improvements here, so it will evolve over time.
It would be good to pop up a mapstyle switcher as with your native Locus mapstyle system (like I had in Elevate 3.0.1 and John has in his themes), so that at least cycling/hiking/city can be chosen.

Quote
And Orux - ah, it needs some beta. Then it's wasting of time for me as I only wanted to see this system working to better understand what you and users expect. In the end, I did it by myself.
It's about the same with OruxMaps (and Atlas/Cruiser), they only have an additional button "check/uncheck all overlays" which is handy sometimes.

I just released Elevate 3.0.2 with overlay support in the Locus version, seems like everything works as expected - except that the selected overlays aren't remembered as mentioned above.
http://www.openandromaps.org/en/new-locus-version-with-support-for-switchable-overlays

Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: john_percy on June 08, 2015, 11:02:57
Quote
Theme switcher - directly open a settings is not exactly what I think it is wanted. I'll anyway do some more UI improvements here, so it will evolve over time.
It would be good to pop up a mapstyle switcher as with your native Locus mapstyle system (like I had in Elevate 3.0.1 and John has in his themes), so that at least cycling/hiking/city can be chosen.

Working on elements used elsewhere in Locus, how about something like this, which pops up a maps style switcher with further settings via an icon on the right:
(http://s8.postimg.org/mwavryqep/Screenshot_2015_06_08_07_43_06.jpg) (http://postimg.org/image/mwavryqep/)
Clicking on the "settings" icon gives (as before) the details screen.
(http://s3.postimg.org/s4meix3b3/Screenshot_2015_06_08_07_42_53.jpg) (http://postimg.org/image/s4meix3b3/)

Title: Re: Mapsforge 0.5
Post by: balloni55 on June 08, 2015, 12:54:00
Quote
I just released Elevate 3.0.2 with overlay support in the Locus version, seems like everything works as expected - except that the selected overlays aren't remembered as mentioned above.
http://www.openandromaps.org/en/new-locus-version-with-support-for-switchable-overlays
thanks Tobias :)
my first impression:
- install with firefox didnt work, with original Samsung Browser no Problem :)
- i have locus installed to internal SD and my Vectormaps are stored on extern SD, Elevate theme was installed automatic to internal theme folder. So at first moment Elevate was not available until i´v moved it to external theme folder. Perhaps you can add this info to your instruction file ;) for new users 8)

On my device i have problems with following settings
- Hiking + puplic transport
- city + puplic transport network
- cycling + puplic transport
up to ZL 15 a blue " i " label and maptiles are displayed well :)
on ZL16 and ZL17 tiles where i-labels on top, didnt zoom :-[
(http://s13.postimg.org/4uedkk6xv/Elevate.jpg) (http://postimg.org/image/4uedkk6xv/)

one additional question, on screenshot are two labels beside, "Rathaus Nord" and "Rathaus Süd" why that, we have only one "Rathaus" :P
Title: Re: Mapsforge 0.5
Post by: Tobias on June 08, 2015, 19:47:15
- install with firefox didnt work, with original Samsung Browser no Problem :)
Yes, that's a limitation of Firefox, maybe we should add that to the FAQ

Quote
- i have locus installed to internal SD and my Vectormaps are stored on extern SD, Elevate theme was installed automatic to internal theme folder. So at first moment Elevate was not available until i´v moved it to external theme folder. Perhaps you can add this info to your instruction file ;) for new users 8)
I think that is a bug limitation in Locus when locus-actions are not using the custom folder you set in the preferences. I use a different setting which works - I added my maps folder on the external SD card via "add local maps" in the maps browser, so the theme folder is on internal SD and locus-actions with automatic install work as expected.


Quote
On my device i have problems with following settings
- Hiking + puplic transport
- city + puplic transport network
- cycling + puplic transport
up to ZL 15 a blue " i " label and maptiles are displayed well :)
on ZL16 and ZL17 tiles where i-labels on top, didnt zoom :-[
(http://s13.postimg.org/4uedkk6xv/Elevate.jpg) (http://postimg.org/image/4uedkk6xv/)

one additional question, on screenshot are two labels beside, "Rathaus Nord" and "Rathaus Süd" why that, we have only one "Rathaus" :P
These are things that I can't influence, some functions of Locus - the blue "i"s and the "Rathaus Nord" popup are not part of the theme. I don't know why the maps don't render at the i-Labels - are you using the SVG theme?

Best regards,
Tobias
Title: Re: Mapsforge 0.5
Post by: balloni55 on June 08, 2015, 19:57:36
Hi Tobias,
thanks for your answer
Quote
are you using the SVG theme?
no, i installed Elevate 240dpi
Quote
These are things that I can't influence, some functions of Locus - the blue "i"s and the "Rathaus Nord" popup are not part of the theme
so i wait on menions comment ;)
Nice evening
Wolfgang
Title: Re: Mapsforge 0.5
Post by: menion on June 08, 2015, 20:19:44
Blue "i" points are points from DB POI from Locus. Fact that you see a blue "i" and not correct icon is probably because Locus is not able to find path to SVG/BMP icon. If this is the problem, expect huge amount of errors on background and slower map rendering.
Title: Re: Mapsforge 0.5
Post by: Tobias on June 08, 2015, 20:37:31
I just tested your screenshot, it works fine for me with the 240dpi version,

Fact that you see a blue "i" and not correct icon is probably because Locus is not able to find path to SVG/BMP icon.

If the icon is missing maybe you haven't copied the "ele_res" when you were moving it manually to the external sd card. It is crucial that this folder is up to date, as some symbols have changed. Have a look here for manual installation:
http://static1.openandromaps.org/wp-content/users/tobias/installation.txt

@menion: Is there anything I can do with the xml file here to make it work with custom maps_vector folders?
http://www.openandromaps.org/wp-content/users/tobias/Elevate3_Locus.xml
Title: Re: Mapsforge 0.5
Post by: menion on June 08, 2015, 20:41:40
Sure sure Tobias. locus-actions should be already aware of these options, but I planned to check it before next beta version! It will definitely work ... have to :)

EDIT: so it should be fixed now. We will see in next Beta version ;).
Title: Re: Mapsforge 0.5
Post by: balloni55 on June 09, 2015, 08:36:50
Quote
If the icon is missing maybe you haven't copied the "ele_res" when you were moving it manually to the external sd card.
sorry for trouble :-[ you are right !
thanks, now it works as expected :)
Title: Re: Mapsforge 0.5
Post by: Tobias on June 12, 2015, 22:14:06
I got some error reports with the theme chooser. If you use map > offline > details, and hit the theme for a second time here, the mapstyle/overlay menu pops up only for a very short time. It's not the case via the button in the panel or via settings > maps advanced.
Title: Re: Mapsforge 0.5
Post by: menion on June 12, 2015, 22:30:52
Ah you are right, thanks. I'll have to change this a little bit (select map and move user to selector on main screen).
Title: Re: Mapsforge 0.5
Post by: fzk on June 14, 2015, 19:47:55
Hmm ... after reading through this long thread I would like to reflect some of my impressions. I don't believe that your strategy concerning mapsforge 0.5 is right. Why not supporting two libraries? The old one (locus mapsforge 0.3) for backward compatibility and the new one (standard mapsforge 0.5) for up-to-date maps and themes? The current strategy to implement only a few new features into the old lib is neither fish, nor flesh.

Regards Klaus
Title: Re: Mapsforge 0.5
Post by: menion on June 14, 2015, 21:26:57
Hello Klaus, please compare speed of MapsForge 0.5 in any of existing app with MapsForge implementation in Locus. Are they same?
Title: Re: Mapsforge 0.5
Post by: jusc on June 14, 2015, 22:16:15
@fzk,

which features are you missing with Locus? As I can see, the most improvements  are still not implemented in mapsforge libraries.
Sure, for theme developers it would be a bit easier to develop themes for all apps, but why should the Locus team not use their own improvements?
Title: Re: Mapsforge 0.5
Post by: fzk on June 15, 2015, 11:04:27
The main problem is compatibility! My requirement is very simple: If someone creates a map (map data + theme) for mapsforge 0.5, this map should be used in every app with mapsforge 0.5 support. That isn't the case for Locus and that's the point.

Here is an example: There was a very old glitch concerning the width of the casing (only half of the casing was printed). The fix lead to the problem, that a map in Locus (without the fix) looks different. Other areas of incompatibility are:
- SVG: handling and scaling different
- DPI: no resolution adaptation

Here are two screenshots, one from Locus and the other from a standard mapsforge 0.5 app, from the same area with the same zoom level:

(http://i.imgur.com/snArHKw.png)

(http://i.imgur.com/BGEyrfk.png)

Regards Klaus

PS: Please don't misunderstand me. I love Locus which is my preferred app. I own three pro licenses just in order to support the project. My hope is, that in one or two years Locus is still my preferred app. But currently I'm not sure about this ... I believe that Locus is moving in a wrong direction.
Title: Re: Mapsforge 0.5
Post by: menion on June 15, 2015, 11:53:32
Understand, and thanks for financial support of course!

Anyway Locus officially do not support new version of MapsForge, that is all. I never wrote it is supported and hope I do not promised, it will be supported. Around two years before wasn't sure, if MapsForge will continue or not. And instead of waiting till something happen, I started to modify this library to exactly match to Locus system.

And wrong direction because I highly optimized older MapsForge library to better fit Locus requirements and because I do not wants to include a third MapsForge library into Locus at once and allow users to choose which they wants to use?

Sorry, but I still prefer speed and optimizations before perfect support of latest "standards". I understand, it complicates work on themes etc. Anyway just take Locus as only supporting MapsForge v. 0.3, nothing more for now.
Title: Re: Mapsforge 0.5
Post by: jusc on June 15, 2015, 12:14:17
@fzk
Maybe I don´t understand correctly what yo mean. But Locus improvements were usefull long time before Mapsforge version 0.5 was out.
And what are the other apps using Mapsforge? Only OruxMaps, Cruiser beta (from member of mapsforge) ore more?
Specially scaling icons and fonts with Locus is very usefull.

And on the other side, with your map, the Freizeitkarte, you go your own way too with all the (to German) translated tags. A time ago I tried to implement these tags into my theme, for using your map too, But I gave it up, because of to hard work (for me).  ;)
Title: Re: Mapsforge 0.5
Post by: fzk on June 15, 2015, 19:48:48
And wrong direction because ... I do not wants to include a third MapsForge library into Locus at once and allow users to choose which they wants to use?

... exactly, that's the point.

Klaus
Title: Re: Mapsforge 0.5
Post by: gynta on June 16, 2015, 22:48:41
Here are two screenshots, one from Locus and the other from a standard mapsforge 0.5 app, from the same area with the same zoom level
Are you sure?
And what was the "standard mapsforge 0.5 app"?
Title: Re: Mapsforge 0.5
Post by: fzk on June 17, 2015, 10:06:49
Here are two screenshots, one from Locus and the other from a standard mapsforge 0.5 app, from the same area with the same zoom level
Are you sure?
And what was the "standard mapsforge 0.5 app"?
Yes, it's in both cases the same zoom level (housenumbers are only displayed only in ZL 18). The first screenshot was taken from "Cruiser beta" (Mapsforge 0.5) and the second (the smaller one) from "Locus Pro". Both screenshot are made on a tablet (Galaxy Tab S 10.5, 2.560x1.600 pixel) from the same map and theme. What I wanted to show: 1. Cruiser has an automatic DPI adaptation, Locus hasn't. Cruiser has a fix concerning the width of the casing (see the houses), Locus hasn't. Both effects are resulting in different looking maps.

Klaus
Title: Re: Mapsforge 0.5
Post by: john_percy on June 17, 2015, 10:40:37
What theme were you using? And was it identical for the two apps?
Title: Re: Mapsforge 0.5
Post by: fzk on June 17, 2015, 15:04:45
What theme were you using? ...
Design "freizeitkarte" from here: http://freizeitkarte-osm.de/android/en/design.html

... And was it identical for the two apps?
Yes.

Klaus
Title: Re: Mapsforge 0.5
Post by: menion on June 18, 2015, 08:05:41
FZK sorry, but I have to say that 0.5 version is really not planned. You still do not answered to my question about compare of speed rendering mainly at high zoom levels. Anyway I believe that adding support for some features included in 0.5 is the way I wants to go, even a slower and more painful.
Title: Re: Mapsforge 0.5
Post by: fzk on June 18, 2015, 11:19:50
FZK sorry, but I have to say that 0.5 version is really not planned. You still do not answered to my question about compare of speed rendering mainly at high zoom levels. Anyway I believe that adding support for some features included in 0.5 is the way I wants to go, even a slower and more painful.
Sorry for not answering. Yes you are right, the Locus rendering speed is (currenty) better. But I think you overestimate this. And the mapsforge devs know that they have improvement potential concerning this point.

Klaus

PS: I regret to hear that you plan to go a proprietary way.
Title: Re: Mapsforge 0.5
Post by: menion on June 18, 2015, 15:36:42
I understand your point of view, on second side I believe my point of view is also logical.

MapsForge is done as universal library. Because of this, at least 50% of code is useless for Locus. Also many optimizations cannot be done because of this "universality". There is also another aspect - it is still not sure, if this project will be success or not. Looks just on current state - https://github.com/mapsforge/mapsforge - last update 3 months old? What may I expect from project, where is not a change for a three months?
Title: Re: Mapsforge 0.5
Post by: jusc on June 18, 2015, 15:44:09
@menion,

the last update is from 31.May 2015 as far as I can see. Please look at the middle of the page.
Title: Re: Mapsforge 0.5
Post by: menion on June 18, 2015, 15:45:36
ah you are right .. tiny changes by author of Cruiser: https://github.com/mapsforge/mapsforge/commits/master
Title: Re: Mapsforge 0.5
Post by: gynta on June 18, 2015, 18:13:20
fzk> same zoom level..
gynta> Are you sure?..
fzk> Yes, it's in both cases the same zoom level.. ...Locus hasn't. Both effects are resulting in different looking maps...

Ah thx, i see...
...but i miss the big "AHA-effect"
I don't see huge differences.

Have a look on this images -> Link (http://www.oldboys.at/comp/) to compare.
(hope it works on all browser)
Sometimes there are missing house numbers in Locus - but in Cruiser also!
Look eg at this detail on the site
(http://www.oldboys.at/comp/shot.png)
Title: Re: Mapsforge 0.5
Post by: fzk on June 18, 2015, 18:24:11
I understand your point of view, on second side I believe my point of view is also logical.
No, it is not logical for me. You don't have to take anything away, you only add value. I will close this discussion from my side. Everything is said, you already have made your decision some month ago. It is what it is.

Klaus
Title: Re: Mapsforge 0.5
Post by: menion on June 18, 2015, 18:33:59
you really think it is so simple to take new MapsForge library and with a few lines of code, attach it to Locus application? Well, sorry. It isn't. I made this decision few years ago, when I started modify old 0.3 library to Locus needs.

You may help me make current system better in similar way like @Tobias. He told me what he wants most - support for styleMenu system. It took me few months, but it is there and it works. In next months, I wants to look on better system of placing labels. If there is something you miss most, simply write me. I'll discuss this with Peter and if it make sense, I'll add that feature into Locus as well. I do not understand where is a big problem here...

Look, I also do not want to complicate life to you as a creator of themes. It do not make sense, to create some extra versions, just because some Menion decided ... agree
Title: Re: Mapsforge 0.5
Post by: jusc on June 18, 2015, 20:24:32
Look, I also do not want to complicate life to you as a creator of themes. It do not make sense, to create some extra versions, just because some Menion decided ... agree
I think that is not possible.
I started with openandromaps and Locus and I tried to make it compatible to the Locus store maps.
Most of tags are working in the same way, some do not work correctly, some are not available in one or both maps.
FZK created his own map with special tags that are not available in OSM.
So, what ever you (Menion) implement into Locus maps library , theme developers have to work on theme specialized for this one map.
I think Mapsforge is the lowest unique level of all themes, but not more.
Title: Re: Mapsforge 0.5
Post by: Tobias on June 18, 2015, 21:29:57
I think Klaus' idea of having two different mapsforge libraries shows some of the ambivalent way the development has taken the last years with mapsforge.
There are community based maps and themes that are made for as many apps as possible, for those are compatibility and an open standard very important (e.g. OpenAndroMaps, Freizeitkarte).
On the other hand Locus built its own proprietary ecosystem with maps, themes and POI database upon mapsforge. For this compatibility is not a big issue, adapting to the needs of this ecosystem is much more important.
Of course there are more sides to it, but with these agendas in mind one library can't really serve both purposes (I'm a bit reminded of internet browsers and html standards ;-)).

What also developed is the usage of mapsforge maps outside of android apps. People are so used to the way they look and appreciate that, so based on mapsforge now there are tileservers, mobac generates raster maps and there are java apps for PCs like Atlas and Route Converter. So route planing even with QuoVadis is possible now.

So of course I would welcome Klaus' idea, as it would take all this into account, but I also appreciate Menion's efforts to at least have some of the new options.

@menion: Just some clarifications on mapsforge development: yes, it was dormant for a while, but last year two major releases were released. Master, which your referred to above, is the stable branch, development happens here and is quite active:
https://github.com/mapsforge/mapsforge/tree/dev

@jusc: As well as Locus has been optimized, mapsforge has been optimized, too, not only new features, and renders differently. Even pure mapsforge 0.3 renders different than Locus nowadays, as Locus is prioritizing captions to symbols (at least it looks so).
Lots of rendering issues have been fixed in mapsforge 0.5. There are so many differences now, not only device dependent scaling and positions of lines vs. fillings. Other things include dy for symbols/captions on areas, dy on ways/pathText/lineSymbol that are scaled the same as stroke-width, automatic position of captions in relation to symbols, priorities that work very well and are very nice combined with a system to switch on/off collision detection per rule etc.
All this gives me more control to get the map rendered without the pitholes and workarounds that were necessary with mapsforge 0.3, and there is more in development (label layer, which solves another big issue with missing POIs/captions).

@fzk: I made a script to convert my mapsforge 0.5 themes, so they work now well with Locus, if you're interested send me your Email.
Title: Re: Mapsforge 0.5
Post by: menion on June 19, 2015, 13:34:49
Nice summary @Tobias , thanks!

My two cents - everything clear and fully understand. Thanks for link on "dev" branch. I was trying now almost four hours to re-use some major parts of current library (mainly stuff around labels), but it is now almost impossible. Since two years, there is now too many differences between modified library in Locus.

So for now, I see few options:

- completely switch to new library (which cause lost of all improvements, massive reduce of speed and increase of battery consumption, lost of auto-loading and probably some more problems, advantage will be better support for styles)

- invest some more time and modify existing Locus version to better fit current MapsForge lib (probably worst variant as more problems will come later because of same reason as now)

- probably best solution from my point of view, is to wait few more months to see, what this lib and it's developers will do. Ten best should be to invest some of my own improvements and then switch completely to next 0.6 version.

So if you excuse me, for now I really do not wants to change library in Locus, because extra work and lost of speed and some features, are for me now worst then benefits. So we will see later, thanks for understanding.
Title: Re: Mapsforge 0.5
Post by: Tobias on June 21, 2015, 10:23:19
- i have locus installed to internal SD and my Vectormaps are stored on extern SD, Elevate theme was installed automatic to internal theme folder. So at first moment Elevate was not available until i´v moved it to external theme folder. Perhaps you can add this info to your instruction file ;) for new users 8)
I just checked, this is fixed with latest updates.
Also the theme switcher works now reliable and remembers the settings. Thanks menion!
Title: Re: Mapsforge 0.5
Post by: menion on June 21, 2015, 10:28:32
At least something, you are welcome!
Title: Re: Mapsforge 0.5
Post by: michaelbechtold on April 02, 2016, 22:05:07
Hi Menion,
not only me who suffers from missing priority support in Locus (see link below). And I am not re-opening the discussion about switching the library! But rather urge for selectively adding major useful features that MapsForge 0.5 delivers. And that a number of your competitors already support. Having villages supersede their neighborhood town or cities is simply a mess in Locus.

Same thing with the new MultiLanguage feature in MF 0.5.

http://www.openandromaps.org/en/oam-forums/topic/place-names-priority#post-8981
Title: Re: Mapsforge 0.5
Post by: menion on April 03, 2016, 13:59:31
Good day Michael, understand. So work on this is one of priorities, but not the biggest one. Not sure if I'll find time on it during April, but hope that during May I'll have finally time to work on it. Thanks for understanding.
Title: Re: Mapsforge 0.5
Post by: kech61 on April 10, 2016, 17:38:55
Hi Menion,

I just tested the Multilanguage feature on Mapsforge with Atlas - this is really great.
Especially for maps covering Russia + Asian/Arab Countrys.
The map I tested was the one of Israel / Syria. Switching between english, arabic, hebrew is perfect fine.

The disadvantage is that these Maps have a different file-format than the V3 maps.
If you could find a way to implement this feature this would add lots of value.

Title: Re: Mapsforge 0.5
Post by: menion on April 10, 2016, 20:32:50
It's already done ;)...  Just not yet public. It will anyway need new map (version 4+) and new theme (version 4+). Themes you probably already have, but any map for tests? Thanks

Tapatalk

Title: Re: Mapsforge 0.5
Post by: kech61 on April 11, 2016, 08:13:59
Hi Menion

These are really good news.

Theme with priority support: http://www.openandromaps.org/wp-content/users/tobias/Elevate3_SVG.zip
With this Theme you can test scaling of SVG's too - if you want  ;)

V4 multilingual map: http://www.openandromaps.org/mapsV4/asia/israel_syria_ml.map
This is the only V4 maps so far on OpenAndroMaps
However, I can make any map you need for testing, just tell me which map you want to have.


Title: Re: Mapsforge 0.5
Post by: menion on April 11, 2016, 08:57:36
Thanks Christian, I'll look at it.

Also maybe useful info for others. I have decided to go little bit different way in the end. Since next version will be in Locus three versions of MapsForge library :).

- quite old for maps version V2
- heavily modified and optimized library for all maps V3 (LoMaps and most of current maps) that will also work with themes version 1, 2, 3, will offer auto-loading and work with LoMaps Poi DB
- current unmodified version of MapsForge library (currently version 0.6, maps V4) that will work only with map themes version 4, no autoloading, no POI Db

Locus automatically decide which map renderer use by version of map.
Title: Re: Mapsforge 0.5
Post by: kech61 on April 11, 2016, 11:49:49

Locus automatically decide which map renderer use by version of map.

Perfect  :)
The Theme in the link is for plain Mapsforge V4 w/o any special Locus elements.

There are Mapsforge pois available from OAM too - so if you want to test those with the plain V4 renderer:
http://ftp5.gwdg.de/pub/misc/openstreetmap/openandromaps/pois/
The mapname.poi.zip are the right ones
Title: Re: Mapsforge 0.5
Post by: menion on April 11, 2016, 12:30:59
Not needed, thanks. No Mapsforge POI will be supported for now, only a map.
Title: Re: Mapsforge 0.5
Post by: Tobias on April 11, 2016, 13:52:46
That's excellent news, thanks!

Locus automatically decide which map renderer use by version of map.
Also by version of map theme?
Title: Re: Mapsforge 0.5
Post by: menion on April 11, 2016, 14:01:31
Also by version of map theme?

Nope. You choose map, Locus check all available themes and offer only these, that has correct version. So for maps V3, only themes with version="1, 2, 3", for maps V4, themes with version="4".
Title: Re: Mapsforge 0.5
Post by: Tobias on April 11, 2016, 14:12:18
So for maps V3, only themes with version="1, 2, 3", for maps V4, themes with version="4".

Hm, that's a bit strict. There's no issue in using V3 maps with V4 themes. Although the numbers differ, they aren't dependent on each other. Mapsforge 0.5 introduced V4 themes, while still producing V3 maps. It would be strange to be able to install V4 themes but not to use them, and will certainly cause support issues.

So if you install and choose a V4 theme switching to standard mapsforge would make sense to me.
Title: Re: Mapsforge 0.5
Post by: menion on April 11, 2016, 14:26:02
I knew you won't like it, but it's only option I may offer for now, thanks for understanding.
Title: Re: Mapsforge 0.5
Post by: LocusUser#1 on April 11, 2016, 14:35:37
So if you install and choose a V4 theme switching to standard mapsforge would make sense to me.

You're right, also for me is this the only correct way to use the different themes versions
Title: Re: Mapsforge 0.5
Post by: ohgood on April 13, 2016, 02:03:04
I would like to test this if you need help
Title: Re: Mapsforge 0.5
Post by: develar on January 03, 2019, 11:46:51
Locus is the only game in town. For simple navigation maybe another apps are suitable, but if you hike with small children, or hike so actively that need to manage your tracks and display on the map, Locus is the only choice for now (I have tried a lot of apps, and bought Android smartphone specially for navigation because Locus not available for iOS).

But problem is that default theme is not so good as Elevate from @Tobias. I have tried to file issues (https://help.locusmap.eu/topic/bench-symbol-is-not-displayed-internal-hikebike-theme), but Elevate has not only minor advantages, but a major advantages also (e.g. compare presentation of cable car near Mittenwald (Germany) — Locus theme doesn't render cable car name opposite to Elevate, so, I have to guess what is this).

So, even if I buy LoMaps (to financially support Locus development), I don't use it. Because as far I understand (and I as far I experienced) for Elevate themes better to use openandromaps.

And now Tobias announced that "OpenAndroMaps will switch to Multilanguage “V4” Maps mid of 2019.". And stated that "The ony real disadvantage over V3 maps, as I know, is that Locus does not support automatic map switching with V4 maps." (because Locus will use not optimised mapsforge engine to render V4 maps). But from this topic I see that maybe will number of other issues. Or it is fixed now?

Could you please shed light on current situation? Tobias answer was a little bit pessimistic — https://www.openandromaps.org/en/locus-direct-install-link-for-multilanguage-v4-maps#comment-9569 Does it mean that you (Locus team) gave up to first class support of Elevate theme? Autoloading not important for me, I worry about battery consumption and potential rendering issues.
Title: Re: Mapsforge 0.5
Post by: menion on January 03, 2019, 15:12:21
Hi,
do not worry, I'll do something with it ... step Tobias made is wanted to be true. I sometimes need some "push" ...

Main topic: https://forum.locusmap.eu/index.php?topic=6434.0
Title: Re: Mapsforge 0.5
Post by: Tobias on January 03, 2019, 20:40:17
And now Tobias announced that "OpenAndroMaps will switch to Multilanguage “V4” Maps mid of 2019.".
That was Christian, not me. But of course I support this :-)